feat(plugins/dates): support duration ranges #1137
Conversation
Fdawgs
force-pushed
the
feat/duration-range
branch
from
1dfce21
to
1351468
Compare
Fdawgs
force-pushed
the
feat/duration-range
branch
from
81d018b
to
2178719
Compare
| if (!['day', 'days'].includes(duration)) { | ||
| end = end.applyShift({ day: -1 }).applyShift({ [duration]: 1 }) | ||
| } |
There was a problem hiding this comment.
Hopefully this is an okay way of doing this.
I found that days was projecting inclusively, but, other durations weren't.
For example 1-2 weeks was returned as 8 days rather than 14 days.
There was a problem hiding this comment.
Great, thanks @spencermountain!
Hopefully last question, do i need to do anything extra for handling past tense in this?
I.e. 2 to 3 weeks ago.
There was a problem hiding this comment.
oh, no problem - i would make a new section, in addition to this '2 to 4 weeks' one, with similar logic.
go for it!
oh, one thing - maybe add a '^in' on the match, so it doesn't interfere with 2 to 3 weeks after june 3rd etc.
lookin good! thanks for the help.
There was a problem hiding this comment.
Cheers @spencermountain, have added the ^in as requested for the future tense match block.
Struggling with the past tense, as you can see from the now failing tests! When you get a spare second could you take a look at the past tense block please? Thought it'd be as simple as flipping the logic.
If it's not a simple fix, happy to just tear out past tense support for now.
There was a problem hiding this comment.
sure - i can merge this to dev and fix the failing tests, if you're ready?
There was a problem hiding this comment.
Sounds good, thanks!
There was a problem hiding this comment.
hey Frazer, haven't forgotten about this - been really busy, then had covid. Will try to get to it shortly.
cheers
There was a problem hiding this comment.
Thanks for taking this on @spencermountain, 42f9cd0 appears to have stopped the ranges from being inclusive?
Fdawgs
force-pushed
the
feat/duration-range
branch
from
73f52c1
to
3adf437
Compare
Fdawgs
force-pushed
the
feat/duration-range
branch
from
3adf437
to
fd45122
Compare
Closes #1135
This will need a squash PR as it's bound to be a mess.